Ticket #465 (closed defect: duplicate)

Opened 11 months ago

Last modified 10 months ago

[PATCH] Make Server.kill more descriptive and resistent to missing PIDs

Reported by: kev..@centropy.com Assigned to:
Priority: major Milestone: The Future
Component: Merb Keywords:
Cc:

Description

Consider the following scenario 

$ merb -c 5
...
$ kill -9 12345 # Or one of the merbs just dies on its own

logs/merb.nnnn.pid now contains a PID that doesn't exist.

Issuing a 'merb -K all' will no longer stop any/all the merb servers. Server.kill is dependent on all the pids from log/*.pid to exist, and to be killable. This patch makes Server.kill more resilient, and also cleans up .pid files for PIDs that no longer exist.

It also improves error messages in the case of failing to kill a merb process.

Attachments

better_merb_killer.diff (1.5 kB) - added by kev..@centropy.com on 01/17/08 10:10:53.
Better Server.kill

Change History

01/17/08 10:10:53 changed by kev..@centropy.com

  • attachment better_merb_killer.diff added.

Better Server.kill

02/11/08 13:39:48 changed by shayarne..@gmail.com

  • status changed from new to closed.
  • resolution set to duplicate.

moved to http://merb.lighthouseapp.com