Ticket #422 (closed enhancement: duplicate)

Opened 4 months ago

Last modified 3 months ago

[PATCH] add support for Thin web server adapter via rack

Reported by: kevw..@gmail.com Assigned to:
Priority: medium Milestone: The Future
Component: Merb Keywords: server rack thin
Cc:

Description

I added support for Thin into server.rb. It is invoked using "-t" or "--thin", as in "merb --thin". I fixed the rack adapter calls to not run mongrel after hitting Ctrl-C to kill the rack-adapted server (webrick, thin).

Attachments

server_thin_adapter.patch (2.1 kB) - added by kevw..@gmail.com on 01/08/08 10:38:51.

Change History

01/08/08 10:38:51 changed by kevw..@gmail.com

  • attachment server_thin_adapter.patch added.

01/08/08 12:27:32 changed by reva..@robertrevans.com

I like this, but I'd like to see where thin goes before this gets committed to merb core. One problem that rails suffers(which I'd hate to see merb suffer with) from is the constant switching between each new technology that comes forth, only to stop using it as quickly as it was adopted. Also, nothing is stopping us from using most of the approaches that thin uses.

01/08/08 17:31:28 changed by e.@brainspl.at

  • milestone changed from 0.5.0 to The Future.

01/08/08 18:04:08 changed by kevw..@gmail.com

While I understand and value a pragmatic approach, this is just an option, just like the Webrick and FastCGI options. Running the normal "merb" command is not harmed.

What about the Webrick and FastCGI fixes I made? Should I make a separate patch for that? To be clear, if you run "merb -w" it will serve your app using Webrick, but when you "Ctrl-C" to quit, it quits Webrick and starts Mongrel.

01/08/08 18:16:05 changed by macournoy..@gmail.com

While I hope Thin gains more exposure and users, I understand your point robert. I'll do everything I can to make Thin good and stable enough to be included in Merb. Please let me know if I can do anything to help.

(I'm the creator of Thin)

02/11/08 13:01:04 changed by shayarne..@gmail.com

  • status changed from new to closed.
  • resolution set to duplicate.

moved to http://merb.lighthouseapp.com