Ticket #373 (closed defect: fixed)

Opened 9 months ago

Last modified 8 months ago

merb_datamapper finders broken

Reported by: ad..@wieck.com Assigned to:
Priority: major Milestone:
Component: Plugin: DataMapper Keywords: merb_datamapper
Cc:

Description

datamapper just deprecated Class[:column => value] finders, and merb_datamapper was using it. I've attached a patch which should fix the one-liner where it's being used.

Attachments

fix.patch (0.5 kB) - added by ad..@wieck.com on 12/19/07 12:52:31.
patch for fixing the one-liner

Change History

12/19/07 12:52:31 changed by ad..@wieck.com

  • attachment fix.patch added.

patch for fixing the one-liner

12/19/07 12:56:53 changed by ssmo..@gmail.com

Maybe this should be it's own ticket, but it actually might be more appropriate to ditch the :id column and use the :session_id as a natural key now that DM supports it. 

property :session_id, :string, :key => true

Session['234233fdsdsf3r3']

Less columns. Faster. Win-win?

12/19/07 13:26:45 changed by ad..@wieck.com

incorporating the patch happened in r1127. gonna play with ssmoot's adjustment next

01/02/08 23:00:33 changed by wyca..@gmail.com

  • status changed from new to closed.
  • resolution set to fixed.

(In [1150]) Closes #373; incorporates ssmoot's idea to improve sessions