Ticket #274 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

[PATCH] Parameterized Actions Require Ruby2Ruby Gem and Other Dependencies

Reported by: mud..@mudge.name Assigned to:
Priority: trivial Milestone: 0.4.2
Component: Merb Keywords:
Cc:

Description

Parameterized actions in controllers will fail with a "wrong number of arguments" internal server error if the Ruby2Ruby gem (and its dependencies) are not installed.

This is indicative of a larger problem: the dependencies for merb are currently ill-defined with conflicting information in the README, on http://merb.devjavu.com/ and as defined in the Gem itself (which only demands mongrel, erubis, mime-types and rubigen).

Perhaps a definitive list could be produced?

Attachments

dependencies.diff (2.4 kB) - added by mud..@mudge.name on 11/09/07 04:46:16.
Adds dependencies to the gem specification and amends the README to better explain them

Change History

11/08/07 01:44:06 changed by chr..@oxdi.eu

Isn't it sequel that requires ruby2ruby not merb? ... are you using merb_sequel?

11/08/07 01:52:03 changed by mud..@mudge.name

I am using merb_datamapper, not merb_sequel and consequently generated my model and controller with the resource generator.

It seems that merb/lib/merb/core_ext/get_args.rb requires Ruby2Ruby but will fail silently as it is wrapped in a begin...end. merb/lib/merb/server.rb uses the get_args method (as well as a ParseTreeArray? object) to parse the controller.action_argument_list which I assume is what powers the parameterized actions in 0.4.0; without ruby2ruby, this method presumably does nothing.

In any case, as well as looking through the source code, simply removing the ruby2ruby gem broke the default generated actions such as show(id) and create(post) which worked otherwise.

11/09/07 04:46:16 changed by mud..@mudge.name

  • attachment dependencies.diff added.

Adds dependencies to the gem specification and amends the README to better explain them

11/09/07 04:48:39 changed by mud..@mudge.name

  • summary changed from Parameterized Actions Require Ruby2Ruby Gem and Other Dependencies to [PATCH] Parameterized Actions Require Ruby2Ruby Gem and Other Dependencies.

11/13/07 10:27:21 changed by iv..@gweezlebur.com

  • milestone changed from The Future to 0.4.2.

11/24/07 14:31:20 changed by e.@brainspl.at

  • status changed from new to closed.
  • resolution set to fixed.

this is fixed in trunk.