Ticket #242 (closed enhancement: fixed)

Opened 1 year ago

Last modified 1 year ago

[PATCH] Reorganize the render specs

Reported by: dudl..@misnomer.us Assigned to:
Priority: major Milestone: 0.3.x
Component: Merb Keywords:
Cc:

Description

Here's a patch that reorganizes the render specs, splitting them up into different contexts for the different rendering engines. I've disabled the builder specs under JRuby because there's some sort of nasty bug in either RSpec or Builder (or JRuby) that causes the spec run to die early. Without this patch, the full spec suite won't run in JRuby.

Attachments

render_spec_reorg.diff (27.5 kB) - added by dudl..@misnomer.us on 10/23/07 14:07:11.
render_spec_reorg2.diff (28.1 kB) - added by dudl..@misnomer.us on 10/23/07 18:25:56.
render_spec_reorg3.diff (28.8 kB) - added by dudl..@misnomer.us on 10/24/07 07:24:01.

Change History

10/23/07 14:07:11 changed by dudl..@misnomer.us

  • attachment render_spec_reorg.diff added.

10/23/07 18:25:56 changed by dudl..@misnomer.us

  • attachment render_spec_reorg2.diff added.

10/23/07 18:30:34 changed by dudl..@misnomer.us

I've updated the patch to also disable Haml specs under JRuby for now. I want to make sure that erb is fully supported and working well before I start worrying about the other template formats.

10/24/07 07:24:01 changed by dudl..@misnomer.us

  • attachment render_spec_reorg3.diff added.

10/24/07 12:45:07 changed by e.@brainspl.at

  • status changed from new to closed.
  • resolution set to fixed.

(In [762]) Applying all dudleys patches to make merb work under jruby, fell back tp json_pure gem but will still try to load the C ext first before falling back to the pure version. closes #231, closes #232, closes #236, closes #242, closes #235 Thanks dudley