Changeset 339

Show
Ignore:
Timestamp:
07/19/07 22:43:58 (1 year ago)
Author:
v..@exdolo.com
Message:

@_params.symbolize_keys! must take place before @_params[_session_id_key] is referred to, since _session_id_key returns a symbol by default. This fixes a bug where session id could not be recognized when passed as part of the query string, even when session_id_cookie_only and query_string_whitelist were set properly in merb.yml

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/lib/merb/merb_controller.rb

    r325 r339  
    6464      end 
    6565       
    66       @_cookies, @_params = cookies, querystring.update(args) 
     66      @_cookies, @_params = cookies.symbolize_keys!, querystring.update(args).symbolize_keys! 
     67       
    6768      if @_params.key?(_session_id_key) && !Merb::Server.config[:session_id_cookie_only] 
    6869        @_cookies[_session_id_key] = @_params[_session_id_key] 
     
    7475        @_cookies[_session_id_key] = @_params[_session_id_key] if Merb::Server.config[:query_string_whitelist].include?("#{params[:controller]}/#{params[:action]}") 
    7576      end   
    76        
    77       @_cookies.symbolize_keys! 
    78       @_params.symbolize_keys! 
    7977       
    8078      # Handle alternate HTTP method passed as _method parameter.